-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[DRAFT] Add a CODEOWNERS file designating oversight of certain Evolution repo content to relevant teams #2938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
stmontgomery
wants to merge
3
commits into
swiftlang:main
Choose a base branch
from
stmontgomery:codeowners
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−0
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
# Lines starting with '#' are comments. | ||
# Each line is a case-sensitive file pattern followed by one or more owners. | ||
# Order is important. The last matching pattern has the most precedence. | ||
# More information: https://docs.github.com/en/articles/about-code-owners | ||
# | ||
# Please mirror the repository's file hierarchy in case-sensitive lexicographic | ||
# order. | ||
|
||
# .github | ||
/.github/CODEOWNERS @shahmishal @swiftlang/core-team | ||
|
||
|
||
### Evolution process documentation | ||
|
||
# The primary Swift Evolution process documentation file. | ||
/process.md @rjmccall | ||
|
||
|
||
### Visions | ||
|
||
# The top-level "visions" directory. | ||
# | ||
# Approval from the Core Team is required to add a new vision document. | ||
/visions/ @swiftlang/core-team | ||
|
||
# Specific vision documents. | ||
# | ||
# Owners typically include the primary author(s) and any sponsoring steering | ||
# group(s) or workgroup(s). | ||
/visions/swift-testing.md @stmontgomery @swiftlang/testing-workgroup | ||
|
||
|
||
### Proposal templates | ||
|
||
# The top-level "proposal-templates" directory. | ||
# | ||
# Approval from the Core Team is required to add a new proposal template. | ||
/proposal-templates/ @swiftlang/core-team | ||
|
||
# Specific proposal templates. | ||
# | ||
# Owners typically include the steering group(s) or workgroup(s) with authority | ||
# to conduct reviews of proposals which follow each template. | ||
/proposal-templates/0000-swift-testing-template.md @swiftlang/testing-workgroup | ||
|
||
|
||
### Proposals | ||
|
||
# The top-level "proposals" directory. | ||
# | ||
# This does not have a designated owner, so its list is empty. | ||
/proposals/ | ||
|
||
# Specific proposal directories. | ||
# | ||
# Owners typically include the steering group(s) or workgroup(s) with authority | ||
# to conduct reviews of proposals placed in each directory. | ||
/proposals/testing/ @swiftlang/testing-workgroup |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start with top level reviewer to be the steering groups and core team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. My only concern is that the top-level
/proposals
directory is fairly high-traffic today, and specifying multiple teams as its code owners might be noisy for the members of those teams since (presumably) they will become default reviewers for each new PR in that space. So I guess it's up to those teams to decide whether they want that.