[DRAFT] Add a CODEOWNERS file designating oversight of certain Evolution repo content to relevant teams #2938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… directories to relevant teams
stmontgomery
requested review from
rjmccall,
shahmishal,
FranzBusch and
hborla
stmontgomery
added
evolution process
stmontgomery
changed the title
shahmishal
reviewed
Aug 12, 2025
| # The top-level "proposals" directory. | ||
| # | ||
| # This does not have a designated owner, so its list is empty. | ||
| /proposals/ |
There was a problem hiding this comment.
Suggested change
| /proposals/ | |
| /proposals/ @swiftlang/ecosystem-steering-group @swiftlang/language-steering-group @swiftlang/platform-steering-group @swiftlang/core-team |
Let's start with top level reviewer to be the steering groups and core team.
There was a problem hiding this comment.
Thanks. My only concern is that the top-level /proposals directory is fairly high-traffic today, and specifying multiple teams as its code owners might be noisy for the members of those teams since (presumably) they will become default reviewers for each new PR in that space. So I guess it's up to those teams to decide whether they want that.
shahmishal
reviewed
Aug 12, 2025
Co-authored-by: Mishal Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub
CODEOWNERSfile to this repo, assigning ownership and oversight responsibilities for certain content to relevant teams. But (importantly) it leaves the top-level/proposalsdirectory without a specific owner.Motivation: This originally came up because some of us on the Testing Workgroup would like to have greater awareness of PRs which modify proposals and other files related to Swift Testing. When I discovered that there was no
CODEOWNERSfile I drafted the file posted here, which assigns ownership of a few other important files and directories in the repo to people or teams I believe are responsible for them as well. The exact owners listed are of course up for discussion!My understanding of
CODEOWNERSfiles in GitHub (per documentation) is that this file alone will not prevent anyone from landing a PR, even if none of the code owners listed have approved it. To begin enforcing such a rule, this repo would need to enable branch protection, and I'm unsure whether that is enabled currently. So this PR, on its own, is not intended to restrict any PRs, although that is a policy we could consider separately.