Skip to content

[DRAFT] Add a CODEOWNERS file designating oversight of certain Evolution repo content to relevant teams #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
# Lines starting with '#' are comments.
# Each line is a case-sensitive file pattern followed by one or more owners.
# Order is important. The last matching pattern has the most precedence.
# More information: https://docs.github.com/en/articles/about-code-owners
#
# Please mirror the repository's file hierarchy in case-sensitive lexicographic
# order.

# .github
/.github/CODEOWNERS @shahmishal


### Evolution process documentation

# The primary Swift Evolution process documentation file.
/process.md @rjmccall


### Visions

# The top-level "visions" directory.
#
# Approval from the Core Team is required to add a new vision document.
/visions/ @swiftlang/core-team

# Specific vision documents.
#
# Owners typically include the primary author(s) and any sponsoring steering
# group(s) or workgroup(s).
/visions/swift-testing.md @stmontgomery @swiftlang/testing-workgroup


### Proposal templates

# The top-level "proposal-templates" directory.
#
# Approval from the Core Team is required to add a new proposal template.
/proposal-templates/ @swiftlang/core-team

# Specific proposal templates.
#
# Owners typically include the steering group(s) or workgroup(s) with authority
# to conduct reviews of proposals which follow each template.
/proposal-templates/0000-swift-testing-template.md @swiftlang/testing-workgroup


### Proposals

# The top-level "proposals" directory.
#
# This does not have a designated owner, so its list is empty.
/proposals/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/proposals/
/proposals/ @swiftlang/ecosystem-steering-group @swiftlang/language-steering-group @swiftlang/platform-steering-group @swiftlang/core-team

Let's start with top level reviewer to be the steering groups and core team.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. My only concern is that the top-level /proposals directory is fairly high-traffic today, and specifying multiple teams as its code owners might be noisy for the members of those teams since (presumably) they will become default reviewers for each new PR in that space. So I guess it's up to those teams to decide whether they want that.


# Specific proposal directories.
#
# Owners typically include the steering group(s) or workgroup(s) with authority
# to conduct reviews of proposals placed in each directory.
/proposals/testing/ @swiftlang/testing-workgroup