Convert FileManager and URL tests to swift-testing #1351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
jrflat
approved these changes
Jun 13, 2025
Contributor
jrflat
left a comment
jrflat
left a comment
There was a problem hiding this comment.
This is awesome thanks for doing this! Left a small nit on test name consistency but otherwise the URL tests LGTM!
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
chloe-yeo
pushed a commit
to chloe-yeo/swift-foundation
that referenced
this pull request
Jun 16, 2025
* Convert FileManager and URL tests to swift-testing * Fix Linux/Windows build failures * Fix Windows build failures * Remove URL prefix from other test functions * Fix Windows build failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
FileManagerandURLtests to swift-testing, based on the patch in #908 but updating to accommodate the latest tests. Additionally, this patch takes a different approach to serialization. Rather than creating a parentSuitefor all tests that change the CWD, it instead defines aGlobalActorto represent the process' CWD. All tests that use the helper functionality to change the CWD await the test on this global actor which ensures that each block that requires a specific, consistent CWD will never run in parallel to another such block so that the CWD is globally serialized amongst any test that uses the helper automatically.