Skip to content

[6.2.1] Use SetFileInformationByHandle for rename in atomic Data.write on Windows #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[6.2.1] Use SetFileInformationByHandle for rename in atomic Data.write on Windows #1487

wants to merge 2 commits into from
+104 −29

Conversation

jmschonfeld
Copy link
Contributor

@compnerd @jmschonfeld
FoundationEssentials: try to make the file atomic behaviour more robu…
bdafbc1 
…st (swiftlang#1485)

We have observed `ERROR_ACCESS_DENIED` in CI on
`SetRenameInformationFile`. Try to make the path more robust by first
performing a kernel based rename with POSIX semantics. This requires
Windows 10 1809+. If that is unsuccessful, verify that attributes are
not to blame.

A failure may still occur if the file is on a different volume. In such
a case, fallback to the `MoveFileExW` operation to perform a copy +
delete operation.

Hopefully this should make the implementation more robust to failures.
@jmschonfeld jmschonfeld requested a review from parkera September 2, 2025 17:10
@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld
Copy link
Contributor Author

Closing while we investigate since this doesn't fully resolve the issue. The package dependency commit has been merged separately

@jmschonfeld jmschonfeld closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkera parkera parkera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmschonfeld @parkera @compnerd