[Commands] Port package refactoring commands to use refactoring actions from swift-syntax #9016
+171
−3,165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
AnthonyLatsis,
bnbarham,
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
owenv
approved these changes
Aug 12, 2025
|
@swift-ci please test |
|
@swift-ci please test self hosted Linux |
|
@swift-ci please test Linux self hosted |
dschaefer2
approved these changes
Aug 12, 2025
|
@swift-ci please test macOS platform |
|
swiftlang/sourcekit-lsp#2235 |
jakepetroules
approved these changes
Aug 13, 2025
|
@swift-ci please test |
xedin
force-pushed
the
use-refactorings-from-syntax
branch
from
4778840 to
ab54292
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test self hosted Windows platform |
|
swiftlang/sourcekit-lsp#2239 |
|
swiftlang/sourcekit-lsp#2239 |
|
swiftlang/sourcekit-lsp#2239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The package manifest refactoring actions are now located in swift-syntax to make it possible to use them across swift-aligned projects like package manager, SourceKit-LSP, and the compiler itself. The first step in support of this transition is to remove the original versions and migrate the users.
Modifications:
Add{Setting, Target, Dependency, TargetDependency}commands have been ported to use refactoring actions from swift-syntax repository that are currently guarded byPackageRefactorSPI.Result:
All of the package refactoring commands now use refactoring actions from swift-syntax repository.