Refactor AdvancedConsoleOutputRecorder to remove fallback recorder dependency #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tienquocbui
requested review from
stmontgomery,
grynspan,
briancroom,
suzannaratcliff and
jerryjrchen
as code owners
grynspan
approved these changes
Oct 5, 2025
grynspan
added
bug
stmontgomery
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AdvancedConsoleOutputRecorder previously stored a full Event.ConsoleOutputRecorder instance (_fallbackRecorder) solely to access its options property. This created an unnecessary dependency on the entire ConsoleOutputRecorder implementation when only the options were needed. This PR removes an unnecessary dependency in AdvancedConsoleOutputRecorder by replacing the stored Event.ConsoleOutputRecorder instance with direct storage of Event.ConsoleOutputRecorder.Options.