Skip to content

Refactor AdvancedConsoleOutputRecorder to remove fallback recorder dependency #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
+4 −4
Merged

Refactor AdvancedConsoleOutputRecorder to remove fallback recorder dependency #1354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Sources/Testing/Events/Recorder/Event.AdvancedConsoleOutputRecorder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,8 @@ extension Event {
/// The write function for this recorder.
let write: @Sendable (String) -> Void

/// The fallback console recorder for standard output.
private let _fallbackRecorder: Event.ConsoleOutputRecorder
/// The base console output options.
private let _baseOptions: Event.ConsoleOutputRecorder.Options

/// Context storage for test information and results.
private let _context: Locked<_Context>
Expand All @@ -159,7 +159,7 @@ extension Event {
init(options: Options = Options(), writingUsing write: @escaping @Sendable (String) -> Void) {
self.options = options
self.write = write
self._fallbackRecorder = Event.ConsoleOutputRecorder(options: options.base, writingUsing: write)
self._baseOptions = options.base
self._context = Locked(rawValue: _Context())
self._humanReadableRecorder = Event.HumanReadableOutputRecorder()
}
Expand Down Expand Up @@ -258,7 +258,7 @@ extension Event.AdvancedConsoleOutputRecorder {
// The hierarchical summary will be shown at the end
switch eventKind {
case .runStarted:
let symbol = Event.Symbol.default.stringValue(options: _fallbackRecorder.options)
let symbol = Event.Symbol.default.stringValue(options: _baseOptions)
write("\(symbol) Test run started.\n")

case .runEnded:
Expand Down