[Diagnostics] Support diagnostics with no location in the new formatter #80477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the swift-syntax Diagnostic machinery now supporting diagnostics that have no associated syntax node (for location information), allow "invalid" source locations to pass in both directions across the diagnostics bridge between the C++ diagnostic machinery and the Swift diagnostic machinery. This eliminates the previous behavior where we would fall back to the LLVM diagnostic printer when there's an invalid source location on a diagnostic. The end-user-visible change is that we'll now get consistently-rendered diagnostics between ones with source locations and ones without source locations.
DougGregor
requested review from
artemcm,
tshortli,
ahoppen,
bnbarham,
CodaFi,
hamishknight,
rintaro,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
Giving up on this in favor of a simpler approach #80874 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the swift-syntax Diagnostic machinery now supporting diagnostics that have no associated syntax node (for location information), allow "invalid" source locations to pass in both directions across the diagnostics bridge between the C++ diagnostic machinery and the Swift diagnostic machinery. This eliminates the previous behavior where we would fall back to the LLVM diagnostic printer when there's an invalid source location on a diagnostic.
The end-user-visible change is that we'll now get consistently-rendered diagnostics between ones with source locations and ones without source locations.