[embedded] Allow casting to tuples and tighten the check which existentials we support in embedded with existentials #85625
Conversation
…ial to concrete type
…d with existentials
aschwaighofer
requested review from
a team,
eeckstein,
jckarter and
rjmccall
as code owners
|
@swift-ci test |
|
includes #85602 |
|
|
||
| // Tuple? | ||
| if !destType.isStruct && !destType.isClass && !destType.isEnum { | ||
| if !destType.isStruct && !destType.isClass && !destType.isEnum && !destType.isTuple { |
There was a problem hiding this comment.
Maybe add a comment listing which types are not supported here? Function types? Also why aren't they supported when tuples are supported? Tuples can have arbitrary element types, including function types, in them.
There was a problem hiding this comment.
There are not tests yet so only the types listed here are "supported" (at this time).
When I add metadata generation for function types they will be added.
The intend is to gradually add more types.
Foreign types don't work either. And the two types I have mentioned I am sure are not a complete list of unsupported types.
There was a problem hiding this comment.
A tuple of function types works because we know how to generate metadata for tuples.
The code to generate function type metadata I have not added yet.
|
@swift-ci test |
|
@swift-ci test windows |
2 participants
No description provided.