-
Notifications
You must be signed in to change notification settings - Fork 19
README.md: Clarify Swift version and SwiftPM instructions #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Also added new SwiftPM CLI commands for adding dependencies.
swift package add-dependency https://github.com/swiftwasm/WasmKit --up-to-next-minor-from 0.1.6 | ||
swift package add-target-dependency WasmKit <your-package-target-name> --package WasmKit | ||
``` | ||
|
||
You can also add the following snippet manually to your `Package.swift` file: | ||
|
||
```swift | ||
dependencies: [ | ||
.package(url: "https://github.com/swiftwasm/WasmKit.git", from: "0.1.0"), | ||
// ...other dependencies | ||
.package(url: "https://github.com/swiftwasm/WasmKit.git", .upToNextMinor(from: "0.1.6")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a release workflow document or an automation to bump up those version strings (in README.md and Sources/CLI/CLI.swift) since I am very sure I'll forget updating them 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super minor wording suggestion
#### Swift Package Manager | ||
|
||
You can use WasmKit as a [Swift Package Manager](https://www.swift.org/documentation/package-manager/) dependency by adding the following to your `Package.swift` file: | ||
You can use WasmKit as a [Swift Package Manager](https://www.swift.org/documentation/package-manager/) dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use WasmKit as a [Swift Package Manager](https://www.swift.org/documentation/package-manager/) dependency. | |
To use WasmKit in your package, add it as a [Swift Package Manager](https://www.swift.org/documentation/package-manager/) dependency. |
Also added new SwiftPM CLI commands for adding dependencies.
List of supported platforms was updated to include the broader support matrix. While some of these newly mentioned Linux distributions aren't directly tested by WasmKit CI, they are tested indirectly on ci.swift.org, as all Swift toolchain Linux jobs build WasmKit as a dependency.