-
Notifications
You must be signed in to change notification settings - Fork 19
README.md: Clarify Swift version and SwiftPM instructions #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaxDesiatov
wants to merge
4
commits into
main
Choose a base branch
from
maxd/update-readme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−6
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,12 +23,30 @@ Hello, World! | |
|
||
#### Swift Package Manager | ||
|
||
You can use WasmKit as a [Swift Package Manager](https://www.swift.org/documentation/package-manager/) dependency by adding the following to your `Package.swift` file: | ||
You can use WasmKit as a [Swift Package Manager](https://www.swift.org/documentation/package-manager/) dependency. | ||
|
||
Run the following commands to add the dependency: | ||
|
||
``` | ||
swift package add-dependency https://github.com/swiftwasm/WasmKit --up-to-next-minor-from 0.1.6 | ||
swift package add-target-dependency WasmKit <your-package-target-name> --package WasmKit | ||
``` | ||
|
||
You can also add the following snippet manually to your `Package.swift` file: | ||
|
||
```swift | ||
dependencies: [ | ||
.package(url: "https://github.com/swiftwasm/WasmKit.git", from: "0.1.0"), | ||
// ...other dependencies | ||
.package(url: "https://github.com/swiftwasm/WasmKit.git", .upToNextMinor(from: "0.1.6")), | ||
Comment on lines
+31
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a release workflow document or an automation to bump up those version strings (in README.md and Sources/CLI/CLI.swift) since I am very sure I'll forget updating them 😅 |
||
], | ||
// ...other package configuration | ||
targets: [ | ||
// ...other targets | ||
.target( | ||
name: "<your-package-target-name>", | ||
dependencies: [.product(name: "WasmKit", package: "WasmKit")], | ||
) | ||
] | ||
``` | ||
|
||
You can find API documentation on the [Swift Package Index](https://swiftpackageindex.com/swiftwasm/WasmKit/main/documentation/wasmkit). | ||
|
@@ -47,11 +65,11 @@ You can find API documentation on the [Swift Package Index](https://swiftpackage | |
|
||
## Supported Platforms | ||
|
||
WasmKit engine works on all major platforms supported by Swift. It is continuously tested on macOS, Ubuntu, and Windows, | ||
WasmKit engine works on all major platforms supported by Swift. It is continuously tested on macOS, Ubuntu, Amazon Linux 2, and Windows, | ||
and should work on the following platforms: | ||
|
||
- macOS 10.13+, iOS 12.0+, tvOS 12.0+, watchOS 6.0+ | ||
- Ubuntu 20.04+ | ||
- Amazon Linux 2, Debian 12, Ubuntu 22.04+, Fedora 39+ | ||
- Windows 10+ | ||
|
||
## Implementation Status | ||
|
@@ -70,12 +88,12 @@ and should work on the following platforms: | |
| | [Memory64](https://github.com/WebAssembly/memory64/blob/main/proposals/memory64/Overview.md) | ✅ Implemented | | ||
| | [Tail call](https://github.com/WebAssembly/tail-call/blob/master/proposals/tail-call/Overview.md) | ✅ Implemented | | ||
| | [Threads and atomics](https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview.md) | 🚧 Parser implemented | | ||
| WASI | WASI Preview 1 | ✅ Implemented | | ||
| WASI | WASI Preview 1 | 🚧 [Majority of syscalls implemented](https://github.com/swiftwasm/WasmKit/blob/d9b56a7b3f979a72682c0d37f6cc71b3493dae65/Tests/WASITests/IntegrationTests.swift#L31) | | ||
|
||
|
||
## Minimum Supported Swift Version | ||
|
||
The minimum supported Swift version of WasmKit is 5.8, which is the version used to bootstrap the Swift toolchain in [ci.swift.org](https://ci.swift.org/). | ||
The minimum supported version is Swift 6.0, which is the version used to bootstrap the Swift toolchain in [ci.swift.org](https://ci.swift.org/). | ||
|
||
## Testing | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.