Symfony 8 support follow-up, PHPUnit 11 #678
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
symfony-8-support
branch
from
2f9393d to
d6646c1
Compare
Member
Author
|
The CI was already red before this PR btw |
dunglas
force-pushed
the
symfony-8-support
branch
from
d6646c1 to
b00e50c
Compare
Member
Kocal
force-pushed
the
symfony-8-support
branch
from
b00e50c to
9ef85eb
Compare
Kocal
commented
Nov 22, 2025
Member
Author
|
@dunglas PR rebased, I also fixed |
xabbuh
reviewed
Nov 22, 2025
xabbuh
reviewed
Nov 22, 2025
Kocal
force-pushed
the
symfony-8-support
branch
5 times, most recently
from
d488b41 to
6a05d18
Compare
Member
Author
|
Everything is green 🙌🏻 |
xabbuh
reviewed
Nov 27, 2025
Kocal
force-pushed
the
symfony-8-support
branch
from
6a05d18 to
cc37227
Compare
xabbuh
reviewed
Nov 27, 2025
xabbuh
reviewed
Nov 27, 2025
Kocal
force-pushed
the
symfony-8-support
branch
from
cc37227 to
db5316b
Compare
Kocal
changed the title
xabbuh
reviewed
Nov 27, 2025
Kocal
force-pushed
the
symfony-8-support
branch
from
db5316b to
b3470ca
Compare
xabbuh
approved these changes
Nov 27, 2025
dunglas
approved these changes
Nov 28, 2025
dunglas
reviewed
Nov 28, 2025
phpstan.neon
Outdated
| - '#Return type \(void\) of method Symfony\\Component\\Panther\\DomCrawler\\Crawler::clear\(\) should be compatible with return type \(Facebook\\WebDriver\\WebDriverElement\) of method Facebook\\WebDriver\\WebDriverElement::clear\(\)#' | ||
| - '#Return type \(ArrayIterator<int, Facebook\\WebDriver\\WebDriverElement>\) of method Symfony\\Component\\Panther\\DomCrawler\\Crawler::getIterator\(\) should be compatible with return type \(ArrayIterator<int, DOMNode>\) of method Symfony\\Component\\DomCrawler\\Crawler::getIterator\(\)#' | ||
| # PHPStan runs with lowest dependencies | ||
| - '#Attribute class PHPUnit\\Framework\\Attributes\\DataProvider does not exist\.#' |
Member
There was a problem hiding this comment.
Actually, we could bump the PHPUnit version in the PHPStan job. We usually run PHPStan only with the latest dependencies.
Member
Author
There was a problem hiding this comment.
Will requires php-webdriver/php-webdriver#1134
This was referenced Nov 28, 2025
Kocal
added a commit
to symfony/ux
that referenced
this pull request
Nov 29, 2025
This PR was merged into the 2.x branch. Discussion ---------- Tests on Symfony 8 stable | Q | A | -------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Documentation? | no <!-- required for new features, or documentation updates --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> The following jobs are still impossible to make them green for the following reasons: - Functional Tests / turbo-tests (8.4, stable): waiting for symfony/panther#678 - Functional Tests / turbo-tests (8.5, stable): sam as above - Functional Tests / turbo-tests (dev, 8.5): same as above - Unit Tests / php (8.4, 8.0.*) : waiting for some `zenstruck/*` packages to be compatible with Symfony 8, and `spatie/phpunit-snapshot-assertions` (but couldn't be installed unless we require PHPUnit 10) - Unit Tests / php (8.5, 8.0.*) : same as above Commits ------- 724429c Tests on Symfony 8 stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIRC the CI was already broken before this PR