[symfony/panther] Add requires for extension#1422
Merged
fabpot merged 1 commit intosymfony:mainfrom Jul 4, 2025
Merged
Conversation
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
fabpot
added a commit
to symfony/flex
that referenced
this pull request
Jul 4, 2025
…peMC) This PR was merged into the 2.x branch. Discussion ---------- Add option to specify version in add lines requires Currently, when requiring `symfony/panther`, Flex adds the following two lines to `phpunit.dist.xml`: ```diff <extensions> + <bootstrap class="Symfony\Component\Panther\ServerExtension" /> + <extension class="Symfony\Component\Panther\ServerExtension" /> </extensions> ``` This isn't entirely correct: the `extension` tag is used for PHPUnit <10, while `bootstrap` is used for PHPUnit >=10. This PR adds support for specifying the required package version for each line, so only the appropriate one is added. Recipes PR: symfony/recipes#1422 Commits ------- 3319fcf Add option to specify version in add lines requires
fabpot
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to symfony/flex#1055