Resolved the OtpInput value mismatch issue for input types text and password.#250
Merged
PaulAndersonS merged 2 commits intomainfrom Aug 21, 2025
Merged
Resolved the OtpInput value mismatch issue for input types text and password.#250PaulAndersonS merged 2 commits intomainfrom
PaulAndersonS merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a value mismatch issue in the SfOtpInput component where control characters (like null characters) were being included in ValueChanged event arguments, causing incorrect reported values. The fix ensures that only visible characters are passed to event handlers for all input types.
- Removes conditional logic that only sanitized control characters for Number input type
- Applies control character filtering to all OTP input types (Text, Password, Number)
- Simplifies the event raising logic by using sanitized values consistently
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
maui/src/OtpInput/SfOtpInput.cs
Outdated
| newValueStr = new string(newValueStr.Where(c => !char.IsControl(c)).ToArray()); | ||
| oldValueStr = new string(oldValueStr.Where(c => !char.IsControl(c)).ToArray()); | ||
| RaiseValueChangedEvent(otpInput, oldValueStr, newValueStr); | ||
| } |
There was a problem hiding this comment.
The null check for ValueChanged is redundant since the subsequent call uses the null-conditional operator (?.). Consider removing this if statement and just calling RaiseValueChangedEvent directly, as the method already handles null events safely.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PaulAndersonS
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause of the Issue
The internal logic for the SfOtpInput component's Value property was including non-printable control characters (specifically, null characters like \0) in its string representation. These characters were likely used as internal placeholders for empty OTP cells. When the ValueChanged event was triggered, these control characters were included in the NewValue and OldValue properties of the event arguments. This caused the reported values to be incorrect (e.g., "1a\0\0" instead of "1a"), leading to a data mismatch and unexpected behavior when consuming the event.
Description of Change
Issues Fixed
Issue : #184