Skip to content

Resolved the OtpInput value mismatch issue for input types text and password. #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulAndersonS merged 2 commits into from
Aug 21, 2025
Merged

Resolved the OtpInput value mismatch issue for input types text and password. #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2da97e5
Resolved the OtpInput value mismatch issue for input types text and p…
Kishore4299 Aug 20, 2025
040f0f1
updated the changes.
Kishore4299 Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 5 additions & 22 deletions maui/src/OtpInput/SfOtpInput.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,27 +937,11 @@ static void OnValuePropertyChanged(BindableObject bindable, object oldValue, obj

string newValueStr = newValue?.ToString() ?? string.Empty;
string oldValueStr = oldValue?.ToString() ?? string.Empty;

if (otpInput.Type == OtpInputType.Number)
{
newValueStr = new string(newValueStr.Where(c => !char.IsControl(c)).ToArray());
oldValueStr = new string(oldValueStr.Where(c => !char.IsControl(c)).ToArray());
}

if (otpInput.ValueChanged != null)
{
if (otpInput.Type == OtpInputType.Number)
{
RaiseValueChangedEvent(otpInput, oldValueStr, newValueStr);
}
else
{
RaiseValueChangedEvent(otpInput, oldValue?.ToString() ?? string.Empty, newValue?.ToString() ?? string.Empty);
}
}

otpInput.UpdateValue(bindable, newValue?? string.Empty);
}
newValueStr = new string(newValueStr.Where(c => !char.IsControl(c)).ToArray());
oldValueStr = new string(oldValueStr.Where(c => !char.IsControl(c)).ToArray());
RaiseValueChangedEvent(otpInput, oldValueStr, newValueStr);
otpInput.UpdateValue(bindable, newValue ?? string.Empty);
}
}

/// <summary>
Expand All @@ -970,7 +954,6 @@ static void OnLengthPropertyChanged(BindableObject bindable, object oldValue, ob
{
if (bindable is SfOtpInput otpInput && newValue is double newLength && oldValue is double oldLength)
{

if (newLength <= 0)
{
newLength = oldLength;
Expand Down
31 changes: 31 additions & 0 deletions maui/tests/Syncfusion.Maui.Toolkit.UnitTest/Editors/SfOtpInputUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,37 @@ public void RaiseValueChangedEvent_ShouldTrigger_ValueChangedEvent()
Assert.True(eventTriggered);
}

[Theory]
[InlineData(OtpInputType.Number, "12", "12")]
[InlineData(OtpInputType.Text, "ab", "ab")]
[InlineData(OtpInputType.Password, "xy", "xy")]
public void ValueChangedEvent_WithPartialInput_DoesNotContainNullCharacters(OtpInputType type, string input, string expected)
{
// Arrange
var otpInput = new SfOtpInput
{
Length = 4,
Type = type
};
string? newValueFromEvent = null;
string? oldValueFromEvent = null;
otpInput.ValueChanged += (sender, e) =>
{
newValueFromEvent = e.NewValue;
oldValueFromEvent = e.OldValue;
};
// Act
otpInput.Value = input;
// Assert
Assert.Equal(expected, newValueFromEvent);
Assert.Equal(string.Empty, oldValueFromEvent);
if (newValueFromEvent != null)
{
Assert.DoesNotContain('\0', newValueFromEvent!);
}
}


#endregion

#region Public Methods
Expand Down