Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Aug 19, 2025

Related to #243

Description

This PR implements the necessary changes to add the Keyboard component to the SpendingAmountScreen

  • Implement the keyboard component and required methods
  • Implement max line parameter in the ApptopBar
  • Adjust padding to make it close to RN
  • Implement E2E test Tags

Preview

transfer_keyboard.mp4

QA Notes

Tests:

  • Open transfer amount screen on a short phone (Mi A2)
  • Perform the full transfer flow

@jvsena42 jvsena42 self-assigned this Aug 19, 2025
@jvsena42 jvsena42 marked this pull request as ready for review August 20, 2025 10:18
@jvsena42 jvsena42 requested a review from ovitrif August 20, 2025 10:27
# Conflicts:
#	docs/e2e-test-ids.md
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Noticed a small UI regression, once fixed we can merge this 🚀

Tested via transfer to spending flow and typing various values using the new keyboard, also using the action buttons: switch unit, 25%, max

@ovitrif ovitrif merged commit be55333 into master Aug 20, 2025
5 checks passed
@ovitrif ovitrif deleted the feat/transfer-keyboard branch August 20, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants