Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Aug 20, 2025

Related to #243

Description

Some Blocktank methods need the node running to work properly

  • Display SyncNodeView on the SpendingAmountScreen when the node is initializing
  • Wait for the node run on the required methods
  • Removed the now unnecessary retry logic

Preview

sync_node_transfer.mp4

QA Notes

Tested:

  • Open the transfer amount screen before the node starts
  • Perform the full transfer flow

@jvsena42 jvsena42 self-assigned this Aug 20, 2025
@jvsena42 jvsena42 marked this pull request as ready for review August 20, 2025 14:41
@jvsena42 jvsena42 requested a review from ovitrif August 20, 2025 14:41
Base automatically changed from feat/transfer-keyboard to master August 20, 2025 14:44
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting for that one UI regression fix from prev PR

Tested with new transfer while node wasn't ready yet.

@jvsena42 jvsena42 mentioned this pull request Aug 20, 2025
6 tasks
@jvsena42 jvsena42 requested a review from ovitrif August 20, 2025 16:29
@ovitrif ovitrif merged commit 081662b into master Aug 20, 2025
5 checks passed
@ovitrif ovitrif deleted the feat/wait-node-start-on-transfer branch August 20, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants