[cherry-pick] target/riscv: fix potential UB reported by ubsan in ac cache lookup #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cache lookup when running OpenOCD built with ubsan enabled I've encountered the following error message: ``` riscv-013.c:204:9: runtime error: null pointer passed as argument 2, ... ``` Checkpatch-ignore: GIT_COMMIT_ID This is caused by a NULL pointer passed to bsearch function when abstract command cache is still empty. This behavor was introduced in commit ab97974 ("target/riscv: implement abstract command cache ...") See: riscv-collab/riscv-openocd#1297 Signed-off-by: Parshintsev Anatoly <[email protected]>
en-sc
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running OpenOCD built with ubsan enabled I've encountered the following error message:
Checkpatch-ignore: GIT_COMMIT_ID
This is caused by a NULL pointer passed to bsearch function when abstract command cache is still empty. This behavor was introduced in commit ab97974 ("target/riscv: implement abstract command cache ...")
See: riscv-collab/riscv-openocd#1297