🌱 log less values in hbmh Reconcile. #1606
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs of caph are hard to read for the human eye because they contain many key-value pairs.
Many of them are duplicated (like the namespace).
Additionally, logging nested key-value pairs should be avoided because they are hard to query. See VictoriaLogs: Key concepts
This PR is focused on the hbmh. Similar PRs could be created for other resources.
Key-value pairs before PR:
The string "my-namespace" is contained 5 times.
Additionally 1: when "Provisioning state changed" is logged, the duration is logged, too.
Additionally 2: The provisioning state is added as key-value pair.
Capi Docs about Logging define some guidelines. But finally:
We should implement it the way it makes sense for us.
PR is WIP.