(@theme-ui/mdx) adopt TypeScript#1031
Merged
hasparus merged 6 commits intosystem-ui:masterfrom Jul 4, 2020
Merged
Conversation
jxnblk
reviewed
Jul 2, 2020
| ElementType, | ||
| ComponentProps, | ||
| } from 'react' | ||
| import styled, { StyledComponent } from '@emotion/styled' |
Member
There was a problem hiding this comment.
NB: more of a note for myself, but we should consider removing the styled dependency for v1 #832
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there 👋
I fixed a few tiny problems in @LA1CH3's PR #703
I included #1002 here to make things easier for myself, what makes code review before aforementioned PR gets merged quite unpleasant. Sorry! 🙈
Actual work here is a66d41b, adc1383, and d69b15d.