-
Notifications
You must be signed in to change notification settings - Fork 667
(@theme-ui/mdx) adopt TypeScript #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f5289f7
feat(@theme-ui/mdx): add TypeScript support
LA1CH3 2f5a6f8
Allow keyof JSX.IntrinsicElements as argument of themed
hasparus ed07c8a
Opt out of typechecking of Styled.X components when "as" prop is used
hasparus ec65e32
Make @theme-ui/mdx strict TypeScript
hasparus 868ef06
(@theme-ui/mdx) update dev deps
hasparus 7d3b8a2
Move MDXProviderComponents from /theme-provider to /mdx
hasparus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| import { jsx, IntrinsicSxElements } from '@theme-ui/core' | ||
| import { css, get, Theme } from '@theme-ui/css' | ||
| import { | ||
| ComponentType, | ||
| FC, | ||
| ReactNode, | ||
| DetailedHTMLProps, | ||
| HTMLAttributes, | ||
| ElementType, | ||
| ComponentProps, | ||
| } from 'react' | ||
| import styled, { StyledComponent } from '@emotion/styled' | ||
| import { MDXProvider as _MDXProvider, useMDXComponents } from '@mdx-js/react' | ||
|
|
||
| type MDXProviderComponentsKnownKeys = { | ||
| [key in keyof IntrinsicSxElements]?: React.ComponentType<any> | string | ||
| } | ||
| export interface MDXProviderComponents extends MDXProviderComponentsKnownKeys { | ||
| [key: string]: React.ComponentType<any> | string | undefined | ||
| } | ||
| export type MdxAliases = { | ||
| [key in keyof IntrinsicSxElements]: keyof JSX.IntrinsicElements | ||
| } | ||
|
|
||
| export type MdxAliasesKeys = 'inlineCode' | 'thematicBreak' | 'root' | ||
|
|
||
| export type ThemedProps = { | ||
| theme: Theme | ||
| } | ||
|
|
||
| export interface MdxProviderProps { | ||
| components?: MDXProviderComponents | ||
| children: ReactNode | ||
| } | ||
|
|
||
| // mdx components | ||
| const tags: Array<keyof IntrinsicSxElements> = [ | ||
| 'p', | ||
| 'b', | ||
| 'i', | ||
| 'a', | ||
| 'h1', | ||
| 'h2', | ||
| 'h3', | ||
| 'h4', | ||
| 'h5', | ||
| 'h6', | ||
| 'img', | ||
| 'pre', | ||
| 'code', | ||
| 'ol', | ||
| 'ul', | ||
| 'li', | ||
| 'blockquote', | ||
| 'hr', | ||
| 'em', | ||
| 'table', | ||
| 'tr', | ||
| 'th', | ||
| 'td', | ||
| 'em', | ||
| 'strong', | ||
| 'del', | ||
| // mdx | ||
| 'inlineCode', | ||
| 'thematicBreak', | ||
| // other | ||
| 'div', | ||
| // theme-ui | ||
| 'root', | ||
| ] | ||
|
|
||
| const aliases = { | ||
| inlineCode: 'code', | ||
| thematicBreak: 'hr', | ||
| root: 'div', | ||
| } as const | ||
|
|
||
| type Aliases = typeof aliases | ||
| const isAlias = (x: string): x is keyof Aliases => x in aliases | ||
|
|
||
| export type StyledComponentName = | ||
| | keyof IntrinsicSxElements | ||
| | keyof JSX.IntrinsicElements | ||
|
|
||
| const alias = (n: StyledComponentName): keyof JSX.IntrinsicElements => | ||
| isAlias(n) ? aliases[n] : n | ||
|
|
||
| export const themed = (key: StyledComponentName) => (props: ThemedProps) => | ||
| css(get(props.theme, `styles.${key}`))(props.theme) | ||
|
|
||
| // opt out of typechecking whenever `as` prop is used | ||
| export type WithPoorAsProp< | ||
| Props, | ||
| As extends ElementType | undefined = undefined | ||
| > = { | ||
| as?: As | ||
| } & (As extends undefined ? Props : { [key: string]: unknown }) | ||
|
|
||
| export interface ThemedComponent<Name extends ElementType> { | ||
| <As extends ElementType | undefined>( | ||
| props: WithPoorAsProp<ComponentProps<Name>, As> | ||
| ): JSX.Element | ||
| } | ||
|
|
||
| export type StyledComponentsDict = { | ||
| [K in keyof IntrinsicSxElements]: K extends keyof Aliases | ||
| ? ThemedComponent<Aliases[K]> | ||
| : K extends keyof JSX.IntrinsicElements | ||
| ? ThemedComponent<K> | ||
| : never | ||
| } | ||
|
|
||
| type StyledDiv = StyledComponent< | ||
| DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, | ||
| ThemedProps, | ||
| Theme | ||
| > | ||
|
|
||
| export const Styled: StyledDiv & StyledComponentsDict = styled('div')( | ||
| themed('div') | ||
| ) as StyledDiv & StyledComponentsDict | ||
|
|
||
| export const components = {} as StyledComponentsDict | ||
|
|
||
| tags.forEach((tag) => { | ||
| // fixme? | ||
| components[tag] = styled(alias(tag))(themed(tag)) as any | ||
| Styled[tag] = components[tag] as any | ||
| }) | ||
|
|
||
| const createComponents = (comps: MDXProviderComponents) => { | ||
| const next = { ...components } | ||
|
|
||
| const componentKeys = Object.keys(comps) as Array<keyof IntrinsicSxElements> | ||
|
|
||
| componentKeys.forEach((key) => { | ||
| ;(next[key] as StyledComponentsDict[typeof key]) = styled<any>(comps[key])( | ||
| themed(key) | ||
| ) as StyledComponentsDict[typeof key] | ||
| }) | ||
| return next | ||
| } | ||
|
|
||
| export const MDXProvider: FC<MdxProviderProps> = ({ components, children }) => { | ||
| const outer = useMDXComponents() as MDXProviderComponents | ||
|
|
||
| return jsx(_MDXProvider, { | ||
| components: createComponents({ ...outer, ...components }), | ||
| children, | ||
| }) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: more of a note for myself, but we should consider removing the
styleddependency for v1 #832