To bring it inline with the improved and mandatory go.mod package system
#104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2023 00:03
…tialized it and was able to get the binary to build
…w the makefile should work straight away without issue
ncw
reviewed
Jan 31, 2023
Collaborator
ncw
left a comment
ncw
left a comment
There was a problem hiding this comment.
This project is in maintenance mode only, but getting it to build is important so thanks for doing this.
I put a couple of minor queries inline.
| @@ -0,0 +1,9 @@ | |||
| # github.com/t3rm1n4l/go-humanize v0.0.0-20121229052809-e7ed15be05eb | |||
Collaborator
There was a problem hiding this comment.
Do we need the vendor directory and this file at all any more?
| go get -u golang.org/x/tools/cmd/goimports | ||
| go get -u github.com/golang/lint/golint | ||
| go mod tidy | ||
| #go get -u github.com/kisielk/errcheck |
Collaborator
There was a problem hiding this comment.
These should probably say
go install github.com/kisielk/errcheck
To bring them up to date!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the use of Gopkg module management and replaced it with
go.modthat is much improved now, and mandatory in modern versions of Go (which I'm not actually a fan of but besides the point).I was unable to build it before but now you can easily build it by pulling it down, calling
go mod tidyandgo mod buildI also updated the
Makefiletoo, so now someone wanting to build it from source should now be able to simply clone it and run themakeand it will build.