Skip to content

To bring it inline with the improved and mandatory go.mod package system #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

To bring it inline with the improved and mandatory go.mod package system #104

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3070427
removed Gopkg things now that go.mod is better and mandatory, and ini…
Jan 31, 2023
49d9958
updated the Makefile so it uses go.mod which is now mandatory, but no…
Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ release:

# Get the build dependencies
build_dep:
go get -u github.com/kisielk/errcheck
go get -u golang.org/x/tools/cmd/goimports
go get -u github.com/golang/lint/golint
go mod tidy
#go get -u github.com/kisielk/errcheck
Copy link
Collaborator

@ncw ncw Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably say

go install github.com/kisielk/errcheck

To bring them up to date!

#go get -u golang.org/x/tools/cmd/goimports
#go get -u github.com/golang/lint/golint

# Do source code quality checks
check:
Expand Down