wip: Improve value parsing #1330
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/better-calc-evaluation
branch
2 times, most recently
from
5c1a316 to
cfa251d
Compare
thecrypticace
force-pushed
the
feat/improve-value-parsing
branch
from
4877d8d to
87ef383
Compare
thecrypticace
added a commit
that referenced
this pull request
Oct 6, 2025
Fixes #1463 We'll have to bail in some cases that we didn't before to fix this. This seems fine though. The core problem was that given this theme: ```css @theme { --radius: calc(var(--radius)); } ``` We'd see this CSS: ```css .rounded { border-radius: calc(var(--radius)); } ``` And we'd try to replace variables in `calc(var(--radius))`. This doesn't _start_ with a var(…) so our recursion guards didn't catch this. This entire system is a bit fragile and I'll be working to clean this up along with how we handle pixel equivalents, light-dark replacements, color-mix replacements, etc… in some future PRs (#1330 is one of those but I want to reorganize + tweak some code first in an earlier PR which will make that one "nicer")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #1316 to simplify and improve value parsing in the language service. It's fairly easy to trip up the regexes we use to match and replace things. This PR changes things around to use proper parsers that implement the same algorithms that CSS uses.
There's still a lot of work left to make use of these new parsers everywhere that is necessary.
Fixes #1210