fix: avoid shell interpretation of PR body in CI workflows#619
fix: avoid shell interpretation of PR body in CI workflows#619
Conversation
Use environment variables and printf instead of direct template substitution to prevent backticks and special characters in PR body from being interpreted as shell commands.
Review Summary by QodoPrevent shell interpretation of PR body in CI workflows
WalkthroughsDescription• Prevent shell interpretation of special characters in PR body • Replace echo with printf and environment variables • Apply fix to both CI workflow files consistently Diagramflowchart LR
A["PR Body with Special Chars"] -->|"Previously: echo with direct substitution"| B["Shell Interprets Backticks/Vars"]
A -->|"Now: env var + printf"| C["Safe File Storage"]
B --> D["Potential Command Execution"]
C --> E["Safe Processing"]
File Changes1. .github/workflows/pr-close-issue.yml
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
|
📦 Plugin has been packaged for this PR. You can download |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #619 +/- ##
===============================================
+ Coverage 53.908% 54.006% +0.098%
+ Complexity 2366 2350 -16
===============================================
Files 259 259
Lines 14699 13541 -1158
Branches 3248 3252 +4
===============================================
- Hits 7924 7313 -611
+ Misses 5331 4787 -544
+ Partials 1444 1441 -3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This PR cherry-picks a fix from easy-yapi to avoid shell interpretation of PR body in CI workflows.
Changes
Source
Cherry-picked from easy-yapi commit df083dff
Related