Warn if result backend is unset #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@s3rius Maybe we should add a warning for other task methods if the result backend is not set. What do you think? |
s3rius
requested changes
Mar 21, 2025
Member
s3rius
left a comment
s3rius
left a comment
There was a problem hiding this comment.
In my opinion the isinstance method is quite expensive to call. We can just add raise in the DummyBackend itself.
Because this isinstance call will be triggered for any ResultBackend. Which might decrease performance.
s3rius
previously approved these changes
Mar 24, 2025
Member
|
I'm wondering. Maybe it'd be better to use warn module to make warnings appear even if you haven't configured logging. |
s3rius
approved these changes
Mar 24, 2025
s3rius
added a commit
that referenced
this pull request
Apr 4, 2025
* warn on .wait_result call if there is no result backend * warn user on dummy result backend level * use warn from warnings module --------- Co-authored-by: Pavel Kirilin <[email protected]>
s3rius
added a commit
that referenced
this pull request
Apr 4, 2025
* warn on .wait_result call if there is no result backend * warn user on dummy result backend level * use warn from warnings module --------- Co-authored-by: Pavel Kirilin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#427