Skip to content

Warn if result backend is unset #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2025
Merged

Warn if result backend is unset #430

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ac6bf7
warn on .wait_result call if there is no result backend
igor-gorohovsky Mar 21, 2025
7bc85e3
warn user on dummy result backend level
igor-gorohovsky Mar 23, 2025
1a55273
use warn from warnings module
igor-gorohovsky Mar 24, 2025
b1d0856
Merge branch 'master' into master
s3rius Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions taskiq/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import asyncio
from logging import getLogger
from time import time
from typing import TYPE_CHECKING, Any, Generic, Optional

Expand All @@ -9,6 +10,7 @@
ResultIsReadyError,
TaskiqResultTimeoutError,
)
from taskiq.result_backends.dummy import DummyResultBackend

if TYPE_CHECKING: # pragma: no cover
from taskiq.abc.result_backend import AsyncResultBackend
Expand All @@ -18,6 +20,9 @@
_ReturnType = TypeVar("_ReturnType")


logger = getLogger("taskiq")


class AsyncTaskiqTask(Generic[_ReturnType]):
"""AsyncTask for AsyncResultBackend."""

Expand Down Expand Up @@ -83,6 +88,9 @@ async def wait_result(
become ready in provided period of time.
:return: task's return value.
"""
if isinstance(self.result_backend, DummyResultBackend):
logger.warning("No result backend configured. Returning dummy result...")

start_time = time()
while not await self.is_ready():
await asyncio.sleep(check_interval)
Expand Down