feat(dialog, fs): Save file on android #1591
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikoto2000
force-pushed
the
save-file-on-android
branch
2 times, most recently
from
3414030 to
e616ef9
Compare
mikoto2000
changed the title
mikoto2000
force-pushed
the
save-file-on-android
branch
from
e616ef9 to
df6d162
Compare
|
Can you open separate PRs for each plugin change? Would be a lot easier to review / request changes / test ❤️ |
|
OK. I separate this PR. |
This was referenced Aug 13, 2024
|
@lucasfernog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1494. (Implementation of save dialog and save text file for Android)
I implemented the save dialog for the dialog plugin and save_text_file for the fs plugin.
As mentioned in the following two comments, saving files on Android requires the use of
activity.getContentResolver().openOutputStream(uri), so I use Uri instead of file path in the communication between the app and the plugin.Also, since the fs plugin requires the use of
activity.getContentResolver().openOutputStream(uri), I've added an Android implementation to the fs plugin.