feat(dialog): Implemented android save dialog. #1657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2024
mikoto2000
changed the title
lucasfernog
approved these changes
Aug 13, 2024
Package Changes Through c2cdc1eThere are 15 changes which include dialog with prerelease, updater with prerelease, barcode-scanner with prerelease, clipboard-manager with prerelease, deep-link with prerelease, global-shortcut with prerelease, window-state with prerelease, biometric with prerelease, geolocation with prerelease, haptics with prerelease, nfc with prerelease, notification with prerelease, shell with prerelease, store with prerelease, fs-js with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Sir-Thom
pushed a commit
to Sir-Thom/plugins-workspace
that referenced
this pull request
Oct 22, 2024
* Implemented android save dialog. * small cleanup * lint --------- Co-authored-by: Lucas Nogueira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1494. (Implementation of save dialog for Android writeTextFile)
Separated #1591 for each plugin change.
I implemented the save dialog for the dialog plugin.
As mentioned in the following two comments, saving files on Android requires the use of
activity.getContentResolver().openOutputStream(uri), so I use Uri instead of file path in the communication between the app and the plugin.File save dialog is not implemented on mobile #1494 (comment)
File save dialog is not implemented on mobile #1494 (comment)