fix(biometric) prompt for fallback credentials when enabled and biometry unavailable on iOS (fix #2632) #2633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjf-dev
changed the title
|
I believe I covered mostly everything, but let me know if anything else is needed for this PR |
pjf-dev
force-pushed
the
fix/biometric/ios-fallback-authentication
branch
from
cab0eff to
b615f47
Compare
Package Changes Through b615f47There are 4 changes which include log with minor, log-js with minor, biometric with patch, biometric-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
gezihuzi
pushed a commit
to Hypobenthos/plugins-workspace
that referenced
this pull request
Jun 22, 2025
…try unavailable on iOS (fix tauri-apps#2632) (tauri-apps#2633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #2632: This fixes the issue described in #2632 where authentication would fail without prompting for fallback credentials when biometry wasn't available or enrolled on iOS platforms.
Root cause
The authenticate function checked the stored biometric status and failed immediately if unavailable, ignoring fallback logic when
allowDeviceCredential = true.Proposed solution
Ensure fallback credential is also disabled before failing early due to biometric availability in the iOS module of the plugin.
Additional Notes
I've tested the fix on a physical iPhone 15 Pro Max running iOS 18.3 and confirmed that a fallback prompt now appears if biometry is disabled and fallback is allowed.