Skip to content

fix(biometric) prompt for fallback credentials when enabled and biometry unavailable on iOS (fix #2632) #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

fix(biometric) prompt for fallback credentials when enabled and biometry unavailable on iOS (fix #2632) #2633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82830de
Fix early biometric status check not accounting for allowDeviceCreden…
pjf-dev Apr 14, 2025
3f74de8
Add change file
pjf-dev Apr 14, 2025
b615f47
Rephrase change to better describe issue
pjf-dev Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/fix-ios-biometry-fallback-auth.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"biometric": patch:bug
"biometric-js": patch:bug
---

Fix biometric plugin ignoring fallback logic when biometry status is unavailable or not enrolled on iOS.
11 changes: 6 additions & 5 deletions plugins/biometric/ios/Sources/BiometricPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,23 +98,24 @@ class BiometricPlugin: Plugin {
}

@objc func authenticate(_ invoke: Invoke) throws {
guard self.status.available else {
let args = try invoke.parseArgs(AuthOptions.self)

let allowDeviceCredential = args.allowDeviceCredential ?? false

guard self.status.available || allowDeviceCredential else {
// Biometry unavailable, fallback disabled
invoke.reject(
self.status.errorReason ?? "",
code: self.status.errorCode ?? ""
)
return
}

let args = try invoke.parseArgs(AuthOptions.self)

let context = LAContext()
context.localizedFallbackTitle = args.fallbackTitle
context.localizedCancelTitle = args.cancelTitle
context.touchIDAuthenticationAllowableReuseDuration = 0

let allowDeviceCredential = args.allowDeviceCredential ?? false

// force system default fallback title if an empty string is provided (the OS hides the fallback button in this case)
if allowDeviceCredential,
let fallbackTitle = context.localizedFallbackTitle,
Expand Down
Loading