-
Notifications
You must be signed in to change notification settings - Fork 425
fix(http): handle status code 204 to use js null fix #2580 #2636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(http): handle status code 204 to use js null fix #2580 #2636
Conversation
Package Changes Through 625fd3dThere are 2 changes which include http with patch, http-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
we probably should do the same for 205 and 304. They will throw the same error (at least in firefox) |
followup to #2636 ref: #2636 (comment)
followup to #2636 ref: #2636 (comment)
followup to #2636 ref: tauri-apps/plugins-workspace#2636 (comment) Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/14548398414 Co-authored-by: amrbashir <[email protected]>
…auri-apps#2636) * fix(http): handle status code 204 to use javascript null * add change file --------- Co-authored-by: Lucas Nogueira <[email protected]>
Description
tauri-apps/plugin-http
handles response as stream which causes errorResponse with null body status cannot have body
in Javascript.Fix
When status is
204
then it usesnull
instead ofreadableStreamBody
.fixes: #2580