Skip to content

Use slug-safe workflow names for log filenames and update harness template #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbrandenburg merged 1 commit into from
Mar 25, 2026
Merged

Use slug-safe workflow names for log filenames and update harness template #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/frontend/src/templates/WORKFLOW_TO_HARNESS_PROMPT_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ Example format:

Log destination preference:

1. `/var/log/made-<workflow-name>-<timestamp>-<PID>.log`
2. `/tmp/made-harness-logs/made-<workflow-name>-<timestamp>-<PID>.log`
1. `/var/log/made-[workflow-name]-[timestamp]-[PID].log`
2. `/tmp/made-harness-logs/made-[workflow-name]-[timestamp]-[PID].log`

Required filename format:

Expand Down Expand Up @@ -443,6 +443,12 @@ Adapt {{AGENT_PARAMETER_FORMAT}} when provided and supported by CLI.
set -euo pipefail

SCRIPT_NAME="{{WORKFLOW_FILE_NAME}}"
WORKFLOW_NAME="${SCRIPT_NAME%.sh}"
WORKFLOW_SLUG=$(printf '%s' "$WORKFLOW_NAME" \
| tr '[:upper:]' '[:lower:]' \
| sed -E 's/[^a-z0-9-]+/-/g; s/^-+//; s/-+$//; s/-+/-/g')
LOG_TIMESTAMP="$(date -u +'%Y%m%dT%H%M%SZ')"
LOG_BASENAME="made-${WORKFLOW_SLUG}-${LOG_TIMESTAMP}-$$.log"

# Argument handling
DRY_RUN=false
Expand All @@ -455,11 +461,11 @@ fi

# Try /var/log first, fallback to /tmp/made-harness-logs
if [[ -w "/var/log" ]]; then
LOG_FILE="/var/log/${SCRIPT_NAME%.sh}.log"
LOG_FILE="/var/log/${LOG_BASENAME}"
else
LOG_DIR="/tmp/made-harness-logs"
mkdir -p "$LOG_DIR"
LOG_FILE="$LOG_DIR/${SCRIPT_NAME%.sh}.log"
LOG_FILE="$LOG_DIR/${LOG_BASENAME}"
fi

log() {
Expand Down
Loading