harness: Add a verifyCallableProperty helper#4468
Merged
Conversation
Ms2ger
reviewed
May 6, 2025
ptomato
approved these changes
May 8, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
No opinion on redundant value so I'll defer to Ms2ger on that, but overall I love this helper
Contributor
Co-authored-by: Ms2ger <Ms2ger@gmail.com>
…ableProperty calls
gibson042
force-pushed
the
2025-05-verifycallableproperty
branch
from
8dcb9c8 to
43243e7
Compare
This was referenced May 19, 2025
gibson042
added a commit
to gibson042/test262
that referenced
this pull request
May 28, 2025
Ref tc39#4468 Match the data property defaults from https://tc39.es/ecma262/multipage/ecmascript-standard-built-in-objects.html (writable true, enumerable false, configurable true).
gibson042
added a commit
to gibson042/test262
that referenced
this pull request
May 28, 2025
Ref tc39#4468 Match the data property defaults from https://tc39.es/ecma262/multipage/ecmascript-standard-built-in-objects.html (writable true, enumerable false, configurable true).
gibson042
added a commit
to gibson042/test262
that referenced
this pull request
May 28, 2025
Ref tc39#4468 Match the data property defaults from https://tc39.es/ecma262/multipage/ecmascript-standard-built-in-objects.html (writable true, enumerable false, configurable true).
gibson042
added a commit
that referenced
this pull request
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECMAScript Standard Built-in Objects specifies non-writable non-enumerable "length" and "name" properties for all built-in functions, but test262 coverage of this is a) incomplete, and b) noisy [in the form of
length.jsandname.jsfiles for covered functions].This PR addresses both issues by introducing a helper to be used in prop-desc.js files for relevant functions, covering their callability, property descriptor attributes, and length/name property descriptors (actually two helpers, with the one for primordial properties intended to be overridden in hardened environments with a version that requires non-configurability).
It is currently only used for global is{Finite,NaN} and parse{Int,Float} functions as a proof of concept (and to limit review burden), but should be capable of covering every function in the spec.