Fix: Global Repository Can't Return Null#53
Merged
tdwesten merged 2 commits intotdwesten:mainfrom Apr 4, 2025
Merged
Conversation
Owner
|
Oh nice! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed Statamic Builder's
GlobalRepository::findmethod is unable to return null fromparent::find. There's a check thatparent::find's result isn't falsey, but returningnullis proper behavior ofGlobalRepository::find. If the result is falsey::finddoes not return in Statamic Builder's implementation, which is a violation of its return type?GlobalSet, causing an error to be thrown.This pull request removes the falsey check and returns the
parent::findresult no questions asked. Test included (checkout 3ef6e1d to get the test to fail).