Skip to content

Conversation

@kurt-mueller-osumc
Copy link
Contributor

This pull requests updates dependencies as well as migrates from Webpack to ViteJS.

@alvi-khan alvi-khan requested a review from tecoholic September 5, 2024 16:33
@tecoholic
Copy link
Owner

@kurt-mueller-osumc Dear lord! Did you actually manage to pull this off? This is amazing. I have tried and given up at least 3 times. I have approved the CI run. Let's see if everything passes. 🤞

@kurt-mueller-osumc
Copy link
Contributor Author

Hi @tecoholic, I didn't update the tests... but I have an instance of your app with vite, standing up in my Azure cloud. I'll see if I can't get tests passing in the next day or so.

@tecoholic
Copy link
Owner

@kurt-mueller-osumc Thank you. I would also try to get a local build working and test the desktop version this week to verify everything is working. This is truly amazing work.

@tecoholic
Copy link
Owner

tecoholic commented Sep 12, 2024

@kurt-mueller-osumc What's the node version used for this upgrade? Can you add the versions of NodeJS and Yarn versions used for this in the PR description?

I was able to get a build to work with Node@20 and Yarn@1

image

However, the interface was broken and there are plenty of warnings in the terminal as well. So I am worried things might be broken.

@kurt-mueller-osumc
Copy link
Contributor Author

kurt-mueller-osumc commented Sep 16, 2024

However, the interface was broken and there are plenty of warnings in the terminal as well. So I am worried things might be broken.

My apologies for the delay in response. I was on vacation :)

When you say the interface, are you talking about javascript assets or image assets?

I've been using the latest version of yarn and node v21.

@tecoholic
Copy link
Owner

tecoholic commented Nov 28, 2024

@kurt-mueller-osumc Hi, it took longer than expected for me to come back to this project. While things are generally okay build wise, I am seeing a bunch of UI issues. I think I might need to upgrade the UI library and make other changes. Can you kindly enable "Allow edits from maintainers" on this PR so I can push the changes to this PR and merge once I have everything working?

Never mind, it's already enabled. I seemed to have missed it.

- Remove webpack config
- Install the latest quasar library with vite plugin
- Update the SaSS imports
- Add APPLICATION_VERSION to the vite config
- update Github Actions to recent versions with Ubuntu 22 for Linux
  build and Node Version 21.
@tecoholic tecoholic changed the title Migrate from webpack to vite Migrate from webpack to Vite & upgrade Tauri to V2 Nov 29, 2024
@tecoholic
Copy link
Owner

Okay. I have tested that this build works and have tagged it as "pre-release" I am merging this to the master branch.

@tecoholic tecoholic merged commit 56458f8 into tecoholic:main Nov 29, 2024
1 of 2 checks passed
@kurt-mueller-osumc
Copy link
Contributor Author

I'm glad to have played a part in updating this project. Thanks for taking the time to review it, fix it up, and merge it.

@tecoholic
Copy link
Owner

@kurt-mueller-osumc Thanks a lot for doing most of the grunt work. I have tried and failed multiple times to do this and the software wouldn't have seen this update for quite a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants