-
Notifications
You must be signed in to change notification settings - Fork 169
Migrate from webpack to Vite & upgrade Tauri to V2 #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kurt-mueller-osumc Dear lord! Did you actually manage to pull this off? This is amazing. I have tried and given up at least 3 times. I have approved the CI run. Let's see if everything passes. 🤞 |
|
Hi @tecoholic, I didn't update the tests... but I have an instance of your app with vite, standing up in my Azure cloud. I'll see if I can't get tests passing in the next day or so. |
|
@kurt-mueller-osumc Thank you. I would also try to get a local build working and test the desktop version this week to verify everything is working. This is truly amazing work. |
|
@kurt-mueller-osumc What's the node version used for this upgrade? Can you add the versions of NodeJS and Yarn versions used for this in the PR description? I was able to get a build to work with Node@20 and Yarn@1 However, the interface was broken and there are plenty of warnings in the terminal as well. So I am worried things might be broken. |
My apologies for the delay in response. I was on vacation :) When you say the interface, are you talking about javascript assets or image assets? I've been using the latest version of yarn and node v21. |
|
@kurt-mueller-osumc Hi, it took longer than expected for me to come back to this project. While things are generally okay build wise, I am seeing a bunch of UI issues. I think I might need to upgrade the UI library and make other changes. Never mind, it's already enabled. I seemed to have missed it. |
- Remove webpack config - Install the latest quasar library with vite plugin - Update the SaSS imports - Add APPLICATION_VERSION to the vite config - update Github Actions to recent versions with Ubuntu 22 for Linux build and Node Version 21.
|
Okay. I have tested that this build works and have tagged it as "pre-release" I am merging this to the master branch. |
|
I'm glad to have played a part in updating this project. Thanks for taking the time to review it, fix it up, and merge it. |
|
@kurt-mueller-osumc Thanks a lot for doing most of the grunt work. I have tried and failed multiple times to do this and the software wouldn't have seen this update for quite a while. |

This pull requests updates dependencies as well as migrates from Webpack to ViteJS.