Don't require password for SMTP connection#739
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the null/empty validation check for the EMAIL_SENDER_PASSWORD configuration value to support SMTP providers that don't require password authentication. However, the implementation is incomplete as it doesn't address how the credentials are used when connecting to the SMTP server.
Changes:
- Removed the ArgumentNullException throw when EMAIL_SENDER_PASSWORD is null or empty
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
teelur
added a commit
that referenced
this pull request
Feb 20, 2026
* don't require password * only set when password
teelur
added a commit
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some providers don't need a password.