Skip to content

Email changes#743

Merged
teelur merged 12 commits intomainfrom
email-changes
Feb 21, 2026
Merged

Email changes#743
teelur merged 12 commits intomainfrom
email-changes

Conversation

@teelur
Copy link
Owner

@teelur teelur commented Feb 21, 2026

  • Update email sender to use non-depricated API
  • Send email when account gets locked out
  • Add a button to resend the confirmation email for unverified accounts
  • Update the registered message to not include the email part when not configured

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the email-sending implementation and expands Identity flows to better support email confirmation and lockout notifications, with corresponding frontend UX updates and dependency bumps.

Changes:

  • Replace legacy SMTP email sending with MailKit/MimeKit and add localized configuration error strings.
  • Extend Identity endpoints to return a richer /register response, send an email on lockout, and support resending confirmation emails; update the client to consume these behaviors.
  • Update client translations and bump several server/test package references.

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
server/BudgetBoard.WebAPI/Utils/Helpers.cs Fix proto detection to use request.Scheme (with forwarded header fallback).
server/BudgetBoard.WebAPI/Utils/EmailSender.cs Switch SMTP implementation to MailKit/MimeKit and localize config errors.
server/BudgetBoard.WebAPI/Resources/ApiResponseStrings.resx Add localized strings for email config errors and lockout email subject/body.
server/BudgetBoard.WebAPI/Overrides/RegisterResponse.cs Add a typed register response contract for the API.
server/BudgetBoard.WebAPI/Overrides/IdentityApiEndpointRouteBuilderExtensions.cs Customize register/login behavior; add lockout email send and new error details.
server/BudgetBoard.WebAPI/BudgetBoard.WebAPI.csproj Bump packages and add MailKit dependency.
server/BudgetBoard.Tests/BudgetBoard.IntegrationTests.csproj Update EF InMemory + coverlet.collector package versions.
server/BudgetBoard.Service/Resources/LogStrings.resx Remove a log string entry (currently still referenced).
server/BudgetBoard.Service/BudgetBoard.Service.csproj Bump Microsoft.Extensions.* package versions.
server/BudgetBoard.Database/BudgetBoard.Database.csproj Bump EF Core/Identity/config package versions.
client/src/models/auth.ts Add RegisterResponse interface matching the new API response.
client/src/app/Unauthorized/Register/Register.tsx Use new register response to tailor “account created” messaging.
client/src/app/Unauthorized/Login/Login.tsx Add “resend confirmation email” button and handle new server error details.
client/public/locales/fr/translation.json Add updated “account created” keys (locale also needs new resend keys).
client/public/locales/en-us/translation.json Add new keys for account-created messaging, resend button, and resend notifications.
client/public/locales/de/translation.json Add updated “account created” keys (locale also needs new resend keys).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@teelur teelur merged commit 4bd6d74 into main Feb 21, 2026
9 checks passed
@teelur teelur deleted the email-changes branch February 21, 2026 19:18
teelur added a commit that referenced this pull request Feb 21, 2026
* i should have broken up these commits

* only send email once

* some tweaks

* Don't show email confirmation message when disabled

* update deps

* disconnect session afterwards

* Update server/BudgetBoard.WebAPI/Utils/Helpers.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update server/BudgetBoard.WebAPI/BudgetBoard.WebAPI.csproj

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Only run when enabled

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
teelur added a commit that referenced this pull request Feb 21, 2026
* Bump tar from 7.5.7 to 7.5.9 in /client (#742)

Bumps [tar](https://github.com/isaacs/node-tar) from 7.5.7 to 7.5.9.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v7.5.7...v7.5.9)

---
updated-dependencies:
- dependency-name: tar
  dependency-version: 7.5.9
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Email changes (#743)

* i should have broken up these commits

* only send email once

* some tweaks

* Don't show email confirmation message when disabled

* update deps

* disconnect session afterwards

* Update server/BudgetBoard.WebAPI/Utils/Helpers.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update server/BudgetBoard.WebAPI/BudgetBoard.WebAPI.csproj

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Only run when enabled

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants