Skip to content

copr.repository provider creates a Repository object#4695

Open
AthreyVinay wants to merge 1 commit intomainfrom
avinay-copr-repo-enumerate
Open

copr.repository provider creates a Repository object#4695
AthreyVinay wants to merge 1 commit intomainfrom
avinay-copr-repo-enumerate

Conversation

@AthreyVinay
Copy link
Member

@AthreyVinay AthreyVinay commented Mar 13, 2026

Resolves #4692

@AthreyVinay AthreyVinay added this to the 1.70 milestone Mar 13, 2026
@AthreyVinay AthreyVinay added step | prepare Stuff related to the prepare step plugin | artifact Related to the `prepare/artifact` plugin. labels Mar 13, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Mar 13, 2026
@AthreyVinay AthreyVinay moved this from backlog to review in planning Mar 13, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 13, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the copr.repository provider to create a Repository object. It introduces a CoprArtifactProvider base class for shared Copr logic. My feedback focuses on improving exception handling and attribute initialization for better robustness.

LecrisUT
LecrisUT reviewed Mar 13, 2026
View reviewed changes
@AthreyVinay AthreyVinay added the ci | full test Pull request is ready for the full test execution label Mar 13, 2026
@AthreyVinay AthreyVinay force-pushed the avinay-copr-repo-enumerate branch from c04945e to bd8dae6 Compare March 16, 2026 10:25
LecrisUT
LecrisUT reviewed Mar 16, 2026
View reviewed changes
@LecrisUT LecrisUT mentioned this pull request Mar 17, 2026
Merged
2 tasks
LecrisUT added a commit that referenced this pull request Mar 18, 2026
@LecrisUT @psss
Drop copr epel6 enablement (#4706)
d9cab5c 
Epel6 chroot on copr has been dropped for a while now. Seems like we can
clean up some code with this.

Extracted from:
#4695 (comment)

---

Pull Request Checklist

* [x] implement the feature
* [x] include a release note

---------

Signed-off-by: Cristian Le <git@lecris.dev>
Co-authored-by: Petr Šplíchal <psplicha@redhat.com>
@AthreyVinay AthreyVinay force-pushed the avinay-copr-repo-enumerate branch 2 times, most recently from 8014c88 to d25eaaf Compare March 19, 2026 09:59
@LecrisUT
Copy link
Member

LecrisUT commented Mar 19, 2026

After a 1-on-1 with @AthreyVinay we found that the copr tests were not being run, Repository.from_url is misused here, and the creation from dnf copr enable is doing a lot of magic behind the scenes. Moving this to implement for now to focus on those issues

@LecrisUT LecrisUT moved this from review to implement in planning Mar 19, 2026
@AthreyVinay AthreyVinay force-pushed the avinay-copr-repo-enumerate branch from d25eaaf to 0a48c6b Compare March 19, 2026 22:03
@AthreyVinay
Copy link
Member Author

AthreyVinay commented Mar 19, 2026

Ok - so I have reverted to using dnf copr enable + guest.pull instead of building the repo URL manually. @LecrisUT would like to know your thoughts on this! Thanks.

@AthreyVinay AthreyVinay moved this from implement to review in planning Mar 19, 2026
@AthreyVinay AthreyVinay force-pushed the avinay-copr-repo-enumerate branch from 0a48c6b to ea55382 Compare March 20, 2026 11:28
@LecrisUT
Copy link
Member

LecrisUT commented Mar 20, 2026 •
edited
Loading

All looks nice and tidy in this form. Only comment would be that self.repository is not currently used, but maybe that is for a later change? 23 things on the agenda following this at least:

  • The Repository.from_* do not accurately account for multiple repos in the content
  • A similar change is needed for copr.build
  • This would probably fail on image mode

@AthreyVinay AthreyVinay requested review from bajertom, happz and thrix March 20, 2026 12:32
@AthreyVinay
Copy link
Member Author

AthreyVinay commented Mar 20, 2026

Only comment would be that self.repository is not currently used, but maybe that is for a later change?

That is accurate - for #4703

@AthreyVinay AthreyVinay force-pushed the avinay-copr-repo-enumerate branch from ea55382 to e076df0 Compare March 20, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LecrisUT LecrisUT LecrisUT approved these changes

@bajertom bajertom Awaiting requested review from bajertom

@thrix thrix Awaiting requested review from thrix

@happz happz Awaiting requested review from happz

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@LecrisUT LecrisUT

@bajertom bajertom

Labels

ci | full test Pull request is ready for the full test execution plugin | artifact Related to the `prepare/artifact` plugin. step | prepare Stuff related to the prepare step

Projects

planning
Status: review

Milestone

1.70

Development

Successfully merging this pull request may close these issues.

copr.repository provider should enumerate packages into artifacts.yaml

5 participants

@AthreyVinay @LecrisUT @happz @thrix @bajertom