Skip to content

Drop copr epel6 enablement#4706

Merged
LecrisUT merged 2 commits intoteemtee:mainfrom
LecrisUT:chore/drop/dead-epel6
Mar 18, 2026
Merged

Drop copr epel6 enablement#4706
LecrisUT merged 2 commits intoteemtee:mainfrom
LecrisUT:chore/drop/dead-epel6

Conversation

@LecrisUT
Copy link
Member

@LecrisUT LecrisUT commented Mar 17, 2026

Epel6 chroot on copr has been dropped for a while now. Seems like we can clean up some code with this.

Extracted from: #4695 (comment)


Pull Request Checklist

  • implement the feature
  • include a release note

@LecrisUT LecrisUT added code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. ci | full test Pull request is ready for the full test execution plugin | install The prepare plugin for installing packages area | maintenance Changes important for efficiency and the long-term health of the project status | blocking other work An important pull request, blocking other pull requests or issues labels Mar 17, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the obsolete logic for enabling copr repositories on epel6. The changes simplify the codebase and also improve correctness on non-epel6 systems where copr plugin installation might fail for other reasons. I have one suggestion to improve the efficiency of enabling multiple copr repositories.

@github-project-automation github-project-automation bot moved this to backlog in planning Mar 17, 2026
@LecrisUT LecrisUT moved this from backlog to review in planning Mar 17, 2026
Copy link
Member

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense. Just a minor release note suggestion.

Copy link
Member

@AthreyVinay AthreyVinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one - lgtm !

@LecrisUT LecrisUT moved this from review to merge in planning Mar 18, 2026
LecrisUT and others added 2 commits March 18, 2026 11:08
Signed-off-by: Cristian Le <git@lecris.dev>
Co-authored-by: Petr Šplíchal <psplicha@redhat.com>
@LecrisUT LecrisUT force-pushed the chore/drop/dead-epel6 branch from bb4c716 to 1c41177 Compare March 18, 2026 10:08
@LecrisUT LecrisUT enabled auto-merge (squash) March 18, 2026 10:11
@LecrisUT LecrisUT merged commit d9cab5c into teemtee:main Mar 18, 2026
31 of 32 checks passed
@github-project-automation github-project-automation bot moved this from merge to done in planning Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area | maintenance Changes important for efficiency and the long-term health of the project ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. plugin | install The prepare plugin for installing packages status | blocking other work An important pull request, blocking other pull requests or issues

Projects

Status: done

Development

Successfully merging this pull request may close these issues.

3 participants