Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes the obsolete logic for enabling copr repositories on epel6. The changes simplify the codebase and also improve correctness on non-epel6 systems where copr plugin installation might fail for other reasons. I have one suggestion to improve the efficiency of enabling multiple copr repositories.
psss
approved these changes
Mar 17, 2026
Member
psss
left a comment
There was a problem hiding this comment.
Yeah, makes sense. Just a minor release note suggestion.
Signed-off-by: Cristian Le <git@lecris.dev>
Co-authored-by: Petr Šplíchal <psplicha@redhat.com>
bb4c716 to
1c41177
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epel6 chroot on copr has been dropped for a while now. Seems like we can clean up some code with this.
Extracted from: #4695 (comment)
Pull Request Checklist