Skip to content

Conversation

@Shivs11
Copy link
Member

@Shivs11 Shivs11 commented Nov 19, 2025

READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.

  • Add InheritedAutoUpgradeInfo message and store it inside of StartWorkflowExecutionAttributes.
  • So that replication, on the passive cluster, can also use the revision number mechanics and ensure that workflow tasks get dispatched to the correct worker.

Breaking changes

  • Discussion to follow

@Shivs11 Shivs11 force-pushed the ss/rev-number-can-child branch from 8766cbe to aaf6f74 Compare November 19, 2025 20:55
@Shivs11 Shivs11 marked this pull request as ready for review November 24, 2025 20:47
@Shivs11 Shivs11 requested review from a team as code owners November 24, 2025 20:47
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. I think the only other things that might be nice to add (but I won't block on):

  • How does this interact with versioning_override? I assume override comes first, but good to say.
  • Mentioned in my previous review: Does SDK need to care about this? If so how?

// AutoUpgrade parent or ContinueAsNew of an AutoUpgrade run, running on the same
// deployment as the parent/previous run)
//
// Note: This field is mutually exclusive with `inherited_pinned_version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Note: This field is mutually exclusive with `inherited_pinned_version.
// Note: This field is mutually exclusive with `inherited_pinned_version`.

@Shivs11
Copy link
Member Author

Shivs11 commented Nov 25, 2025

@Sushisource -

  1. VersioningOverride will have precedence over this value. I can include that in the docstring in a follow-up commit.
  2. [Apologies]. The SDK doesn't need to be interacting with this in any manner. All the checks are being done in the server to ensure that we don't bounce between versions for autoUpgrade workflows.

@Sushisource
Copy link
Member

@Sushisource -

1. VersioningOverride will have precedence over this value. I can include that in the docstring in a follow-up commit.

2. [Apologies]. The SDK doesn't need to be interacting with this in any manner. All the checks are being done in the server to ensure that we don't bounce between versions for autoUpgrade workflows.

Super, thanks. Putting that info about SDK into the docstring would probably be good too.

@Shivs11 Shivs11 enabled auto-merge (squash) November 26, 2025 23:14
@Shivs11 Shivs11 merged commit 94708bf into master Nov 26, 2025
4 checks passed
@Shivs11 Shivs11 deleted the ss/rev-number-can-child branch November 26, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants