-
Notifications
You must be signed in to change notification settings - Fork 84
[Worker Versioning GA]: Add autoUpgrade information inside of events #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7f3719d
add revision number for startWorkflowExecution so that child workflow…
Shivs11 3eb3f3c
one-of in WorkflowExecutionStartedEventAttributes
Shivs11 aaf6f74
Merge branch 'master' into ss/rev-number-can-child
Shivs11 ac1fd5e
removed one-of and updated comment
Shivs11 063a3f0
moved inheritedAutoUpgradeInfo to deployment package so that it can b…
Shivs11 b740fd6
Merge branch 'master' into ss/rev-number-can-child
Shivs11 9e3bfdb
cleanup non-required field
Shivs11 a412b7b
comments
Shivs11 16055ca
address comments
Shivs11 2dda312
address more comments, make docstring better
Shivs11 d4aa55c
add that SDK is not required to interact with this field
Shivs11 c3708ed
make behavior and version comment concise
Shivs11 e3083e1
Merge branch 'master' into ss/rev-number-can-child
Shivs11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -136,22 +136,45 @@ message WorkflowExecutionStartedEventAttributes { | |||||
| reserved 36; | ||||||
| reserved "parent_pinned_deployment_version"; | ||||||
|
|
||||||
|
|
||||||
| // If present, the new workflow should start on this version with pinned base behavior. | ||||||
| // Child of pinned parent will inherit the parent's version if the Child's Task Queue belongs to that version. | ||||||
| // | ||||||
| // New run initiated by workflow ContinueAsNew of pinned run, will inherit the previous run's version if the | ||||||
| // A new run initiated by workflow ContinueAsNew of pinned run, will inherit the previous run's version if the | ||||||
| // new run's Task Queue belongs to that version. | ||||||
| // | ||||||
| // New run initiated by workflow Cron will never inherit. | ||||||
| // A new run initiated by workflow Cron will never inherit. | ||||||
| // | ||||||
| // New run initiated by workflow Retry will only inherit if the retried run is effectively pinned at the time | ||||||
| // A new run initiated by workflow Retry will only inherit if the retried run is effectively pinned at the time | ||||||
| // of retry, and the retried run inherited a pinned version when it started (ie. it is a child of a pinned | ||||||
| // parent, or a CaN of a pinned run, and is running on a Task Queue in the inherited version). | ||||||
| // | ||||||
| // Pinned override is inherited if Task Queue of new run is compatible with the override version. | ||||||
| // Override is inherited separately and takes precedence over inherited base version. | ||||||
| // | ||||||
| // Note: This field is mutually exclusive with inherited_auto_upgrade_info. | ||||||
| temporal.api.deployment.v1.WorkerDeploymentVersion inherited_pinned_version = 37; | ||||||
|
|
||||||
| // If present, the new workflow commences with AutoUpgrade behavior. Before dispatching the | ||||||
Shivs11 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
| // first workflow task, this field is set to the deployment version on which the parent/ | ||||||
| // previous run was operating. This inheritance only happens when the task queues belong to | ||||||
| // the same deployment version. The first workflow task will then be dispatched to either | ||||||
| // this inherited deployment version, or the current deployment version of the task queue's | ||||||
| // Deployment. After the first workflow task, the effective behavior depends on worker-sent | ||||||
| // values in subsequent workflow tasks. | ||||||
| // | ||||||
| // Inheritance rules: | ||||||
| // - ContinueAsNew and child workflows: inherit AutoUpgrade behavior and deployment version | ||||||
| // - Cron: never inherits | ||||||
| // - Retry: inherits only if the retried run is effectively AutoUpgrade at the time of | ||||||
| // retry, and inherited AutoUpgrade behavior when it started (i.e. it is a child of an | ||||||
| // AutoUpgrade parent or ContinueAsNew of an AutoUpgrade run, running on the same | ||||||
| // deployment as the parent/previous run) | ||||||
| // | ||||||
| // Note: This field is mutually exclusive with `inherited_pinned_version. | ||||||
|
||||||
| // Note: This field is mutually exclusive with `inherited_pinned_version. | |
| // Note: This field is mutually exclusive with `inherited_pinned_version`. |
Shivs11 marked this conversation as resolved.
Show resolved
Hide resolved
Shivs11 marked this conversation as resolved.
Show resolved
Hide resolved
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.