update SDK & server dependencies for grpc-proxy & Nexus#381
Merged
bergundy merged 11 commits intotemporalio:mainfrom Jan 17, 2025
Merged
update SDK & server dependencies for grpc-proxy & Nexus#381bergundy merged 11 commits intotemporalio:mainfrom
bergundy merged 11 commits intotemporalio:mainfrom
Conversation
bergundy
reviewed
Jan 16, 2025
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Thanks, I'll defer to @Quinn-With-Two-Ns for approving.
codec-server/go.mod
Outdated
| github.com/google/uuid v1.6.0 | ||
| go.temporal.io/api v1.43.0 | ||
| go.temporal.io/sdk v1.32.1 | ||
| go.temporal.io/server v1.22.4 |
Member
There was a problem hiding this comment.
We should update the server too here.
Member
There was a problem hiding this comment.
Gonna have to so CI can pass I believe
Contributor
Author
There was a problem hiding this comment.
@bergundy I noticed you had pushed a commit to this PR, but my force-push removed it. Did we do the same update, or was your commit inclusive of more?
Member
There was a problem hiding this comment.
Not sure, I can look at this tomorrow.
cretz
approved these changes
Jan 16, 2025
robzienert
force-pushed
the
update-for-nexus
branch
from
f0ab67d to
53c6770
Compare
bergundy
approved these changes
Jan 17, 2025
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Please accept the suggestions before merging.
Co-authored-by: Roey Berman <roey.berman@gmail.com>
Co-authored-by: Roey Berman <roey.berman@gmail.com>
Co-authored-by: Roey Berman <roey.berman@gmail.com>
Co-authored-by: Roey Berman <roey.berman@gmail.com>
Co-authored-by: Roey Berman <roey.berman@gmail.com>
Co-authored-by: Roey Berman <roey.berman@gmail.com>
Co-authored-by: Roey Berman <roey.berman@gmail.com>
Co-authored-by: Roey Berman <roey.berman@gmail.com>
Co-authored-by: Roey Berman <roey.berman@gmail.com>
bergundy
reviewed
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Updates SDK and Server dependencies.
Why?
Triaging a bug observed internally using a grpc-proxy with workflows that use a Nexus Operation. I wanted to reproduce with purely OSS sample code, which required updating dependencies to get the Nexus workflowservice methods.
Checklist
Running both
grpc-proxyandnexussamples. I didn't test the OIDC path, however.