feat: add last_sdk_version to workflow activation #1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-olszewski
force-pushed
the
olszewski/feat_include_sdk_version_wfl_activation
branch
from
b09b27b to
ad45085
Compare
Sushisource
approved these changes
Oct 23, 2025
chris-olszewski
deleted the
olszewski/feat_include_sdk_version_wfl_activation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add
last_sdk_versionfield toWorkflowActivationWhy?
In order to provide a backwards compatible fix for temporalio/sdk-typescript#1677, we need to be able to identify if the workflow was ran with an affected version. Making this field available to lang SDKs allow us to do this check.
Checklist
Part of [Bug] Upgrading OTel Interceptor to 1.11.5+ breaks signal-with-start and may cause NDE sdk-typescript#1677
How was this tested:
Unsure any additional testing is needed as this change just depends on
InternalFlagsbehavior which already has tests for extracting metadata from workflow task completed events.Any docs updates needed?
No