Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ message WorkflowActivation {
// build id, if this worker was using the deprecated Build ID-only
// feature(s).
common.WorkerDeploymentVersion deployment_version_for_current_task = 9;
// The last seen SDK version from the most recent WFT completed event
string last_sdk_version = 10;
}

message WorkflowActivationJob {
Expand Down
1 change: 1 addition & 0 deletions crates/common/src/protos/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,7 @@ pub mod coresdk {
history_size_bytes: 0,
continue_as_new_suggested: false,
deployment_version_for_current_task: None,
last_sdk_version: String::new(),
}
}

Expand Down
9 changes: 9 additions & 0 deletions crates/sdk-core/src/internal_flags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,15 @@ impl InternalFlags {
Self::Disabled => Either::Right(iter::empty()),
}
}

pub(crate) fn last_sdk_version(&self) -> Option<&str> {
match self {
InternalFlags::Enabled {
last_sdk_version, ..
} if !last_sdk_version.is_empty() => Some(last_sdk_version),
InternalFlags::Enabled { .. } | InternalFlags::Disabled => None,
}
}
}

impl CoreInternalFlags {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,11 @@ impl WorkflowMachines {
continue_as_new_suggested: self.continue_as_new_suggested,
deployment_version_for_current_task: deployment_version_for_current_task
.map(Into::into),
last_sdk_version: (*self.observed_internal_flags)
.borrow()
.last_sdk_version()
.unwrap_or_default()
.to_owned(),
}
}

Expand Down