Agents SDK: startActivity spans should finish when the activity has been sent to the server #1172
Conversation
| set_header_from_context(input, temporalio.workflow.payload_converter()) | ||
| if trace: | ||
| with custom_span( | ||
| name="temporal:signalChildWorkflow", | ||
| data={"workflowId": input.child_workflow_id}, | ||
| ): | ||
| set_header_from_context(input, temporalio.workflow.payload_converter()) |
There was a problem hiding this comment.
I see this code changed here and in a few places. IIRC, it was intentional that we did set_header_from_context inside the with custom_span so the header has that current span serialized (and therefore spans that occur inside workflow will have this as a parent).
There was a problem hiding this comment.
It was, but I think it wasn't actually correct to do. Since the signal span would more or less immediately end, I think it is misleading to parent the child workflow execution to the signal span. Rather, the child workflow is parented to the parent workflow's span (or whatever user defined span is active at that point in the workflow).
There was a problem hiding this comment.
It's the same change I am making for startActivity essentially, the activity execution isn't parented to the startActivity, it's parented to the workflow, because really the start has already completed.
3 participants
What was changed
Instead of tracking the startActivity span across the duration of the activity, leave that up to the workflow. StartActivity is finished upon scheduling
Why?
Checklist
Closes [Bug] Langfuse Tracing Not Working with Temporal OpenAI Agents Plugin #1136
How was this tested: