fix typing when passing loaded config into Client.connect #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r if 'address' not provided by config
tconley1428
approved these changes
Jul 25, 2025
| if self.namespace is not None: | ||
| config["namespace"] = self.namespace | ||
| if self.api_key: | ||
| if self.api_key is not None: |
Contributor
There was a problem hiding this comment.
Don't think this change is necessary, but I don't mind it.
THardy98
force-pushed
the
fix_connect_config_typing
branch
from
40a650b to
c48b357
Compare
THardy98
changed the title
THardy98
force-pushed
the
fix_connect_config_typing
branch
from
c48b357 to
a299415
Compare
THardy98
changed the title
THardy98
changed the title
tconley1428
added a commit
that referenced
this pull request
Aug 28, 2025
…r if 'address' not provided by config (#998) Co-authored-by: tconley1428 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Fixes typing when passing a loaded config into
Client.connect. Raises an error if the loaded config does not provide anaddressWhy?
Fixes linting errors
How was this tested:
Run linter, add small test to check that error is raised correctly
Any docs updates needed?
no