Skip to content

Conversation

@dandavison
Copy link
Contributor

@dandavison dandavison commented Oct 27, 2025

Update to latest protos from temporalio/api#640

Removes WorkerHeartbeat -- this has already been done in main (2403695) but we are not currently rebased on main.


Note

Adds PollActivityExecution across server and client layers while removing DescribeActivityExecution and GetActivityExecutionResult; updates quotas/metadata/interceptors/mocks and bumps Temporal API dep.

  • API surface:
    • Add PollActivityExecution to FrontendHandler and client wrappers (client_gen, metric_client_gen, retryable_client_gen), log tags, redirection maps, and tests.
    • Remove DescribeActivityExecution and GetActivityExecutionResult from clients, metrics, retryable clients, redirection maps, metadata, log tags, and mocks.
  • Quotas/Priorities:
    • Classify PollActivityExecution as long-running and set priority (P4); update long-poll docs.
  • Metadata:
    • Map PollActivityExecution as polling-capable in common/api/metadata.go.
  • Server/frontend:
    • Drop worker heartbeat forwarding from PollWorkflowTaskQueue.
  • Tooling/Deps:
    • Bump go.temporal.io/api dependency; clean getproto import map (remove enums/v1/id.proto).

Written by Cursor Bugbot for commit 21cdb37. This will update automatically on new commits. Configure here.

@dandavison dandavison requested review from a team as code owners October 27, 2025 16:11
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note my comment below.

"/temporal.api.workflowservice.v1.WorkflowService/UpdateWorkflowExecution": 1,
"/temporal.api.workflowservice.v1.WorkflowService/GetWorkflowExecutionHistory": 1,
"/temporal.api.workflowservice.v1.WorkflowService/PollNexusTaskQueue": 1,
// TODO: Map to PollActivityResult if request is long-polling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this TODO here to make sure that we categorize long poll requests correctly. This request isn't always a long poll and needs some pre-processing to categorize.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see the special treatment of GetWorkflowExecutionHistory now. Added a TODO back in.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Base automatically changed from saa-start-exec-task to standalone-activity October 30, 2025 19:34
@dandavison dandavison merged commit ded2e1b into standalone-activity Oct 30, 2025
55 of 57 checks passed
@dandavison dandavison deleted the update-protos branch October 30, 2025 20:25
dandavison added a commit that referenced this pull request Oct 30, 2025
dandavison added a commit that referenced this pull request Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants