Skip to content

Update standalone activity protos #8549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dandavison merged 8 commits into from
Oct 30, 2025
Merged

Update standalone activity protos #8549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1f4ef6c
Update protos
dandavison Oct 25, 2025
15d4de3
Delete usage of WorkerHeartbeat
dandavison Oct 25, 2025
b9a3b07
Update ExecutionAPICountLimitOverride and long-running methods docume…
dandavison Oct 27, 2025
190175e
Revert descriptor changes
dandavison Oct 27, 2025
7f3f9d0
Improve comment
dandavison Oct 27, 2025
360c058
Reinstate TODO
dandavison Oct 27, 2025
2dafaf8
Mark as PollingCapable
dandavison Oct 27, 2025
21cdb37
Update to protos from api#640
dandavison Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions chasm/lib/activity/frontend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ type FrontendHandler interface {
StartActivityExecution(ctx context.Context, req *workflowservice.StartActivityExecutionRequest) (*workflowservice.StartActivityExecutionResponse, error)
CountActivityExecutions(context.Context, *workflowservice.CountActivityExecutionsRequest) (*workflowservice.CountActivityExecutionsResponse, error)
DeleteActivityExecution(context.Context, *workflowservice.DeleteActivityExecutionRequest) (*workflowservice.DeleteActivityExecutionResponse, error)
DescribeActivityExecution(context.Context, *workflowservice.DescribeActivityExecutionRequest) (*workflowservice.DescribeActivityExecutionResponse, error)
GetActivityExecutionResult(context.Context, *workflowservice.GetActivityExecutionResultRequest) (*workflowservice.GetActivityExecutionResultResponse, error)
PollActivityExecution(context.Context, *workflowservice.PollActivityExecutionRequest) (*workflowservice.PollActivityExecutionResponse, error)
ListActivityExecutions(context.Context, *workflowservice.ListActivityExecutionsRequest) (*workflowservice.ListActivityExecutionsResponse, error)
RequestCancelActivityExecution(context.Context, *workflowservice.RequestCancelActivityExecutionRequest) (*workflowservice.RequestCancelActivityExecutionResponse, error)
TerminateActivityExecution(context.Context, *workflowservice.TerminateActivityExecutionRequest) (*workflowservice.TerminateActivityExecutionResponse, error)
Expand Down
30 changes: 10 additions & 20 deletions client/frontend/client_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 14 additions & 28 deletions client/frontend/metric_client_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

45 changes: 15 additions & 30 deletions client/frontend/retryable_client_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions cmd/tools/getproto/files.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions common/api/metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@ var (
"RespondActivityTaskCanceledById": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
"CountActivityExecutions": {Scope: ScopeNamespace, Access: AccessReadOnly, Polling: PollingNone},
"DeleteActivityExecution": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
"DescribeActivityExecution": {Scope: ScopeNamespace, Access: AccessReadOnly, Polling: PollingNone},
"GetActivityExecutionResult": {Scope: ScopeNamespace, Access: AccessReadOnly, Polling: PollingNone},
"PollActivityExecution": {Scope: ScopeNamespace, Access: AccessReadOnly, Polling: PollingCapable},
"ListActivityExecutions": {Scope: ScopeNamespace, Access: AccessReadOnly, Polling: PollingNone},
"PauseActivityExecution": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
"RequestCancelActivityExecution": {Scope: ScopeNamespace, Access: AccessWrite, Polling: PollingNone},
Expand Down
22 changes: 8 additions & 14 deletions common/rpc/interceptor/logtags/workflow_service_server_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions common/rpc/interceptor/redirection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,7 @@ var (
"StartActivityExecution": func() any { return &workflowservice.StartActivityExecutionResponse{} },
"CountActivityExecutions": func() any { return &workflowservice.CountActivityExecutionsResponse{} },
"ListActivityExecutions": func() any { return &workflowservice.ListActivityExecutionsResponse{} },
"DescribeActivityExecution": func() any { return &workflowservice.DescribeActivityExecutionResponse{} },
"GetActivityExecutionResult": func() any { return &workflowservice.GetActivityExecutionResultResponse{} },
"PollActivityExecution": func() any { return &workflowservice.PollActivityExecutionResponse{} },
"RequestCancelActivityExecution": func() any { return &workflowservice.RequestCancelActivityExecutionResponse{} },
"TerminateActivityExecution": func() any { return &workflowservice.TerminateActivityExecutionResponse{} },
"DeleteActivityExecution": func() any { return &workflowservice.DeleteActivityExecutionResponse{} },
Expand Down
3 changes: 1 addition & 2 deletions common/rpc/interceptor/redirection_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,7 @@ func (s *redirectionInterceptorSuite) TestGlobalAPI() {
"StartActivityExecution": {},
"CountActivityExecutions": {},
"ListActivityExecutions": {},
"DescribeActivityExecution": {},
"GetActivityExecutionResult": {},
"PollActivityExecution": {},
"RequestCancelActivityExecution": {},
"TerminateActivityExecution": {},
"DeleteActivityExecution": {},
Expand Down
60 changes: 20 additions & 40 deletions common/testing/mockapi/workflowservicemock/v1/service_grpc.pb.mock.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ require (
go.opentelemetry.io/otel/sdk v1.34.0
go.opentelemetry.io/otel/sdk/metric v1.34.0
go.opentelemetry.io/otel/trace v1.34.0
go.temporal.io/api v1.53.1-0.20251013183714-d8d86d018c50
go.temporal.io/api v1.53.1-0.20251030194917-59ee62fd34be
go.temporal.io/sdk v1.35.0
go.uber.org/fx v1.23.0
go.uber.org/mock v0.6.0
Expand Down
4 changes: 4 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,10 @@ go.opentelemetry.io/proto/otlp v1.5.0 h1:xJvq7gMzB31/d406fB8U5CBdyQGw4P399D1aQWU
go.opentelemetry.io/proto/otlp v1.5.0/go.mod h1:keN8WnHxOy8PG0rQZjJJ5A2ebUoafqWp0eVQ4yIXvJ4=
go.temporal.io/api v1.53.1-0.20251013183714-d8d86d018c50 h1:oHDlsZ9dXFWFgYAnxB3kKj/n3uk1aM8GYUDhZv5gTXk=
go.temporal.io/api v1.53.1-0.20251013183714-d8d86d018c50/go.mod h1:iaxoP/9OXMJcQkETTECfwYq4cw/bj4nwov8b3ZLVnXM=
go.temporal.io/api v1.53.1-0.20251025101057-28854633c4af h1:Gx/YInPOk+EiikphRsDLQzdBlgJ8OwYlyEptXTI9fTA=
go.temporal.io/api v1.53.1-0.20251025101057-28854633c4af/go.mod h1:iaxoP/9OXMJcQkETTECfwYq4cw/bj4nwov8b3ZLVnXM=
go.temporal.io/api v1.53.1-0.20251030194917-59ee62fd34be h1:54bFSQitEpvQ1qj4qkiYLYTtZQd2AYUw29d7FC+VkzI=
go.temporal.io/api v1.53.1-0.20251030194917-59ee62fd34be/go.mod h1:iaxoP/9OXMJcQkETTECfwYq4cw/bj4nwov8b3ZLVnXM=
go.temporal.io/sdk v1.35.0 h1:lRNAQ5As9rLgYa7HBvnmKyzxLcdElTuoFJ0FXM/AsLQ=
go.temporal.io/sdk v1.35.0/go.mod h1:1q5MuLc2MEJ4lneZTHJzpVebW2oZnyxoIOWX3oFVebw=
go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
Expand Down
Loading
Loading